follows: refactor FollowButton.js #1780
Merged
+94
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vellip
approved these changes
Mar 6, 2025
| return ( | ||
| <span className="a4-follow"> | ||
| <span className={`a4-follow ${useMbStyles ? 'a4-follow--proposal-style' : ''}`}> |
There was a problem hiding this comment.
Instead of asking for specific projects, can we not add like a className prop or customClassName or similar and then you pass a4-follow--proposal-style in MB as a prop
There was a problem hiding this comment.
oh good catch! that was unintended, i forgot to change it!
| const buttonClasses = following ? 'a4-btn a4-btn--following' : 'a4-btn a4-btn--follow' | ||
|
|
||
| const AlertPortal = () => { | ||
| if (!alert || !alertTarget) return null |
There was a problem hiding this comment.
Should this actually be && or ||?
Comment on lines
74
to
75
| const container = document.getElementById(alertTarget) | ||
| if (!container) return null |
There was a problem hiding this comment.
Maybe add a console.error or throw an error, I think that's better for devs to understand where the issue is then.
hom3mad3
force-pushed
the
mr-2025-03-fix-follow
branch
2 times, most recently
from
009715a to
8f018fb
Compare
hom3mad3
force-pushed
the
mr-2025-03-fix-follow
branch
from
8f018fb to
3f25bd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor FollowButton to allow for alerts outside the container